Skip to content

[DRAFT] Add RekorV2Client #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ All versions prior to 0.9.0 are untracked.
* Added support for ed25519 keys.
[#1377](https://github.com/sigstore/sigstore-python/pull/1377)

* Added a `RekorV2Client` for posting new entries to a Rekor V2 instance.

### Fixed

* Avoid instantiation issues with `TransparencyLogEntry` when `InclusionPromise` is not present.
Expand Down
187 changes: 187 additions & 0 deletions sigstore/_internal/rekor/client_v2.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
# Copyright 2025 The Sigstore Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""
Client implementation for interacting with RekorV2.
"""

from __future__ import annotations

import json
import logging

import rekor_types
import requests
from cryptography.hazmat.primitives import serialization
from cryptography.x509 import Certificate

from sigstore._internal import USER_AGENT
from sigstore._internal.rekor.v2_types.dev.sigstore.common.v1 import PublicKeyDetails
from sigstore._internal.rekor.v2_types.dev.sigstore.rekor import v2
from sigstore._internal.rekor.v2_types.io import intoto as v2_intoto
from sigstore.dsse import Envelope
from sigstore.hashes import Hashed
from sigstore.models import LogEntry

_logger = logging.getLogger(__name__)

DEFAULT_REKOR_URL = "https://rekor.sigstore.dev"
STAGING_REKOR_URL = "https://rekor.sigstage.dev"

DEFAULT_KEY_DETAILS = PublicKeyDetails.PKIX_ECDSA_P384_SHA_256


class RekorV2Client:
"""The internal Rekor client for the v2 API"""

# TODO: implement get_tile, get_entry_bundle, get_checkpoint.

def __init__(self, base_url: str) -> None:
"""
Create a new `RekorV2Client` from the given URL.
"""
self.url = f"{base_url}/api/v2"
self.session = requests.Session()
self.session.headers.update(
{
"Content-Type": "application/json",
"Accept": "application/json",
"User-Agent": USER_AGENT,
}
)

def __del__(self) -> None:
"""
Terminates the underlying network session.
"""
self.session.close()

def create_entry(self, request: v2.CreateEntryRequest) -> LogEntry:
"""
Submit a new entry for inclusion in the Rekor log.
"""
# TODO: There may be a bug in betterproto, where the V_0_0_2 is changed to V002,
# Or it is an issue with the proto `json_value`.
# See https://github.com/sigstore/rekor-tiles/blob/bd5893730de581629a5f475923c663f776793496/api/proto/rekor_service.proto#L66.
payload = request.to_dict()
if "hashedRekordRequestV002" in payload:
payload["hashedRekordRequestV0_0_2"] = payload.pop(
"hashedRekordRequestV002"
)
if "dsseRequestV002" in payload:
payload["dsseRequestV0_0_2"] = payload.pop("dsseRequestV002")
_logger.debug(f"request: {json.dumps(payload)}")
resp = self.session.post(f"{self.url}/log/entries", json=payload)

try:
resp.raise_for_status()
except requests.HTTPError as http_error:
raise RekorClientError(http_error)

integrated_entry = resp.json()
_logger.debug(f"integrated: {integrated_entry}")
return LogEntry._from_dict_rekor(integrated_entry)

@classmethod
def _build_hashed_rekord_create_entry_request(
cls,
artifact_hashed_input: Hashed,
artifact_signature: bytes,
signining_certificate: Certificate,
) -> v2.CreateEntryRequest:
return v2.CreateEntryRequest(
hashed_rekord_request_v0_0_2=v2.HashedRekordRequestV002(
digest=artifact_hashed_input.digest,
signature=v2.Signature(
content=artifact_signature,
verifier=v2.Verifier(
public_key=v2.PublicKey(
raw_bytes=signining_certificate.public_key().public_bytes(
encoding=serialization.Encoding.DER,
format=serialization.PublicFormat.SubjectPublicKeyInfo,
)
),
key_details=DEFAULT_KEY_DETAILS, # type: ignore[arg-type]
),
),
)
)

@classmethod
def _build_dsse_create_entry_request(
cls, envelope: Envelope, signing_certificate: Certificate
) -> v2.CreateEntryRequest:
return v2.CreateEntryRequest(
dsse_request_v0_0_2=v2.DsseRequestV002(
envelope=v2_intoto.Envelope(
payload=envelope._inner.payload,
payload_type=envelope._inner.payload_type,
signatures=[
v2_intoto.Signature(
keyid=signature.keyid,
sig=signature.sig,
)
for signature in envelope._inner.signatures
],
),
verifiers=[
v2.Verifier(
public_key=v2.PublicKey(
raw_bytes=signing_certificate.public_key().public_bytes(
encoding=serialization.Encoding.DER,
format=serialization.PublicFormat.SubjectPublicKeyInfo,
)
),
key_details=DEFAULT_KEY_DETAILS, # type: ignore[arg-type]
)
],
)
)

@classmethod
def production(cls) -> RekorV2Client:
"""
Returns a `RekorV2Client` populated with the default Rekor production instance.
"""
return cls(
DEFAULT_REKOR_URL,
)

@classmethod
def staging(cls) -> RekorV2Client:
"""
Returns a `RekorV2Client` populated with the default Rekor staging instance.
"""
return cls(STAGING_REKOR_URL)


class RekorClientError(Exception):
"""
A generic error in the Rekor client.
"""

def __init__(self, http_error: requests.HTTPError):
"""
Create a new `RekorClientError` from the given `requests.HTTPError`.
"""
if http_error.response is not None:
try:
error = rekor_types.Error.model_validate_json(http_error.response.text)
super().__init__(f"{error.code}: {error.message}")
except Exception:
super().__init__(
f"Rekor returned an unknown error with HTTP {http_error.response.status_code}"
)
else:
super().__init__(f"Unexpected Rekor error: {http_error}")
11 changes: 11 additions & 0 deletions sigstore/_internal/rekor/v2_types/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# V2 Types

TODO: Eventually move these types to sigstore/protobuf-specs.

These are types meant to be used with RekorV2.

Generated from running `make python` in sigstore/rekor-tiles to generate (although not checked into git) and copied into here, **plus** formatting and lint fixes (lots of `noqa` comments).

Linting is still not expected to pass yet, since `interrogate` docstrings for **all** modules and classes.

Eventually, we will move these types into sigstore/protobuf-specs.
3 changes: 3 additions & 0 deletions sigstore/_internal/rekor/v2_types/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""
Types for RekorV2
"""
3 changes: 3 additions & 0 deletions sigstore/_internal/rekor/v2_types/dev/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""
Types used for RekorV2
"""
3 changes: 3 additions & 0 deletions sigstore/_internal/rekor/v2_types/dev/sigstore/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""
Types for RekorV2
"""
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""
Common types used by Sigstore services
"""
Loading
Loading