Skip to content

feat:(oidc) derive audience claim from client_id in IdentityToken #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SequeI
Copy link

@SequeI SequeI commented May 21, 2025

Summary

Resolves #1401

This change updates the OIDC identity token handling to derive the audience (aud) claim from the provided client_id, rather than hardcoding it to "sigstore". (The default value for client_id is 'sigstore' though)

hatch run python -m sigstore --trust-config trust_config.json sign \
--oidc-client-id=<ClientID> --oidc-issuer <customIssuer> \
--oauth-force-oob --overwrite --verbose test.txt
hatch run python -m sigstore --trust-config trust_config.json verify identity \
--cert-identity=<Identity> --cert-oidc-issuer <customIssuer> --verbose test.txt

Signed and verified using a custom Sigstore instance alongside a custom OIDC client and all worked.

Release Note

  • derive audience claim from client_id in IdentityToken

Documentation

None

@SequeI SequeI force-pushed the audClaim branch 2 times, most recently from d29ccef to 194101d Compare May 21, 2025 12:21
@SequeI SequeI changed the title feat: adding --oidc-audience (aud) claim configuration options feat:(oidc) derive audience claim from client_id in IdentityToken May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing: hardcoded audience value won't allow a custom sigstore clients audience claim
1 participant