Skip to content

Fix timestamp tests #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Fix timestamp tests #1406

merged 3 commits into from
May 22, 2025

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented May 21, 2025

Client support for Rekor V2: sigstore-python

Summary

Resolves #1405

Fixes the TSA tests that run in CI.

Testing

TSA tests now succeed without error

https://github.com/sigstore/sigstore-python/actions/runs/15173918751/job/42670246342?pr=1406#step:7:1070

============================= test session starts ==============================
platform linux -- Python 3.9.22, pytest-8.3.5, pluggy-1.6.0
rootdir: /home/runner/work/sigstore-python/sigstore-python
configfile: pyproject.toml
plugins: cov-6.1.1
collected 194 items / 187 deselected / 7 selected

2025-05-21T22:37:02.364Z	INFO	restapi/configure_timestamp_server.go:103	[fv-az1372-936/dQUJcpATck-000001] "POST http://localhost:3000/api/v1/timestamp HTTP/1.1" from 127.0.0.1:32890 - 201 1145B in 321.278µs
2025-05-21T22:37:02.378Z	INFO	restapi/configure_timestamp_server.go:103	[fv-az1372-936/dQUJcpATck-000002] "POST http://localhost:3000/api/v1/timestamp HTTP/1.1" from 127.0.0.1:32904 - 201 1144B in 242.6µs
test/unit/internal/test_timestamping.py ....                             [ 57%]
test/unit/test_sign.py sss                                               [100%]

Release Note

  • Fixed the Timestamp Authority test data to use the latest signing config format.

Documentation

None

ramonpetgrave64 and others added 3 commits May 21, 2025 22:19
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

This is not the first time the optional tsa tests are silently failing on CI... would be good to have a better solution here

@jku jku enabled auto-merge (squash) May 22, 2025 07:57
auto-merge was automatically disabled May 22, 2025 13:30

Pull request was closed

@jku
Copy link
Member

jku commented May 22, 2025

/gcbrun

@jku jku merged commit 916c2c5 into sigstore:main May 22, 2025
30 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: TSA tests silently failing
2 participants