Skip to content

use new SigningConfig generator in fixtures #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

ramonpetgrave64
Copy link
Contributor

Client support for Rekor V2: sigstore-python

Summary

Resolves #1408

Fixes the fixtures that produce a SigningContext.

Release Note

Tests: Updated the staging and sign_ctx_and_ident_for_env fixtures to use the new methods
for generating a SigningContext.

Documentation

None

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64
Copy link
Contributor Author

ramonpetgrave64 commented May 22, 2025

@jku @woodruffw

@ramonpetgrave64 ramonpetgrave64 changed the title use new signing generator in fixtures use new SigningConfig generator in fixtures May 22, 2025
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm also unsure why the original PR didn't fail but this looks correct.

@jku
Copy link
Member

jku commented May 23, 2025

/gcbrun

@jku jku merged commit cdf6892 into sigstore:main May 23, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: staging fixture not working
2 participants