Skip to content

bump sigstore-rekor-types, add NOTE #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

bump sigstore-rekor-types, add NOTE #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies = [
"rfc8785 ~= 0.1.2",
"sigstore-protobuf-specs ~= 0.3.1",
# NOTE(ww): Under active development, so strictly pinned.
"sigstore-rekor-types == 0.0.12",
"sigstore-rekor-types == 0.0.13",
"tuf ~= 4.0",
"platformdirs ~= 4.2",
]
Expand Down
8 changes: 6 additions & 2 deletions sigstore/sign.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,12 @@ def sign_dsse(

# Create the proposed DSSE log entry
proposed_entry = rekor_types.Dsse(
spec=rekor_types.dsse.DsseV001Schema(
proposed_content=rekor_types.dsse.ProposedContent(
spec=rekor_types.dsse.DsseSchema(
# NOTE: mypy can't see that this kwarg is correct due to two interacting
# behaviors/bugs (one pydantic, one datamodel-codegen):
# See: <https://github.com/pydantic/pydantic/discussions/7418#discussioncomment-9024927>
# See: <https://github.com/koxudaxi/datamodel-code-generator/issues/1903>
proposed_content=rekor_types.dsse.ProposedContent( # type: ignore[call-arg]
envelope=content.to_json(),
verifiers=[b64_cert.decode()],
),
Expand Down
Loading