Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for url as a connect option? #41

Open
OrcaXS opened this issue Apr 7, 2020 · 6 comments
Open

Support for url as a connect option? #41

OrcaXS opened this issue Apr 7, 2020 · 6 comments
Labels
features The new features

Comments

@OrcaXS
Copy link

OrcaXS commented Apr 7, 2020

It's more convenient than separate host/port options in some environments, like CI.
Since https://github.com/luin/ioredis supports redis:// directly ootb, it would make the transition easier if tedis could support this as well.

Thanks!

@dasoncheng dasoncheng added the features The new features label Apr 8, 2020
@danielfroz
Copy link

@OrcaXS I did a fork of this project (https://github.com/danielfroz/tedis). Also wanted URL.... so it's implemented in this fork. Examples under .spec.ts files.

@randallb
Copy link

randallb commented Jun 6, 2020

@danielfroz PR possible?

@danielfroz
Copy link

danielfroz commented Jun 10, 2020

hi @randallb it is possible. The thing here is that tedis has problems with the parser and not supporting Streams / PUB SUB, etc... So created this fork to support my needs. Didn't receive any reply to my comment / issue. Perhaps not desired. Not sure....
In either case tedis fork mentioned is working ok.
Anyways... will check later the current status of this project - maybe contribute with PR for everything - again not sure as I am really busy with other things.

@orimdominic
Copy link

orimdominic commented May 18, 2021

@danielfroz Nice work! Thanks!

How does one use your fork?

@danielfroz
Copy link

Hi @sudo-kaizen . You either reference it locally (path reference locally) or create a private repository and deploy it ... something like @sudo-kaizen/tedis.

But honestly not sure if you will need it . Long time I don't follow Tedis development... so maybe the author already fixed the code and implemented the requested feature. Would check the code first before testing my fork.

Hope this helps

@orimdominic
Copy link

@danielfroz

Yup! I eventually ended up using handy-redis though.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features The new features
Projects
None yet
Development

No branches or pull requests

5 participants