Skip to content

Commit 6af5604

Browse files
committed
Split useMemo in two
1 parent 4432a4a commit 6af5604

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/h5web/visualizations/shared/MappedVis.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ function MappedVis<T>(props: Props<T>): ReactElement {
1616
const { component: Component, dataset, value, mapperState } = props;
1717
const rawDims = (dataset.shape as HDF5SimpleShape).dims;
1818

19-
const dataArray = useMemo(() => {
20-
const baseArray = ndarray<T>(value.flat(Infinity) as T[], rawDims);
19+
const baseArray = useMemo(() => {
20+
return ndarray<T>(value.flat(Infinity) as T[], rawDims);
21+
}, [rawDims, value]);
2122

23+
const dataArray = useMemo(() => {
2224
if (mapperState === undefined) {
2325
return baseArray;
2426
}
@@ -33,7 +35,7 @@ function MappedVis<T>(props: Props<T>): ReactElement {
3335

3436
// Create ndarray from mapped view so `dataArray.data` only contains values relevant to vis
3537
return ndarray<T>(unpack(mappedView).flat(), mappedView.shape);
36-
}, [value, rawDims, mapperState]);
38+
}, [mapperState, baseArray]);
3739

3840
return <Component dataArray={dataArray} />;
3941
}

0 commit comments

Comments
 (0)