Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modify_attens from setup_phase_delay #351

Open
jlashner opened this issue Jun 9, 2023 Discussed in #350 · 0 comments
Open

Remove modify_attens from setup_phase_delay #351

jlashner opened this issue Jun 9, 2023 Discussed in #350 · 0 comments

Comments

@jlashner
Copy link
Collaborator

jlashner commented Jun 9, 2023

Discussed in #350

Originally posted by yaqiongl June 9, 2023
This is a really small issue, it seems uxm_setup.setup_phase_delay does not use the args modify_attens at all, and would change the uc and dc attens anyway with modify_attens=False
It wouldn't cause any trouble if just doing uxm_setup.uxm_setup, it just causes a bit confusion if someone runs this function individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant