Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uxm_relock does not use tone_power info in dev_cfg #414

Open
msilvafe opened this issue Feb 1, 2024 · 2 comments
Open

uxm_relock does not use tone_power info in dev_cfg #414

msilvafe opened this issue Feb 1, 2024 · 2 comments

Comments

@msilvafe
Copy link
Contributor

msilvafe commented Feb 1, 2024

https://github.com/simonsobs/sodetlib/blob/32f4a8c5bdf545ca41efbb4aa7ba9a2addec0589/sodetlib/operations/uxm_relock.py#L45C1-L56C1

uxm_relock needs to pass the tone_power in the dev_cfg to S.setup_notches or S.relock.

@jlashner
Copy link
Collaborator

jlashner commented Feb 1, 2024

I'm pretty sure that this line sets the default tone powers that are used for each band:

S.amplitude_scale[band] = band_cfg['tone_power']

so when it runs reload_tune, it is using the tone-power in the device cfg. We should check that this is the case though, and probably allow for setting tone-power via kwarg to the reload_tune function.

@msilvafe
Copy link
Contributor Author

msilvafe commented Feb 1, 2024

Ya it changed that variable in the SmurfControl name space but when I looked at the S.get_amplitude_scale_array(4) after relock was done everything was still at tone_power = 12 despite cfg.dev.bands[4]['tone_power'] being 9 and S.amplitud_scale[4] being 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants