Skip to content

Error: JSON not found #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgeCarpenter opened this issue Apr 15, 2025 · 7 comments
Closed

Error: JSON not found #67

GeorgeCarpenter opened this issue Apr 15, 2025 · 7 comments
Assignees

Comments

@GeorgeCarpenter
Copy link
Contributor

When I use bytedance-research/UI-TARS-7B-DPO as the model to run Agent-S2, the output of the model does not contain json during the generation of the DAG. I think maybe the error is due to the ability limitation of UI-TARS-7B-DPO. Can you generate json when using UI-TARS-7B-DPO as the model for Agent-S2? @alckasoc

@alckasoc
Copy link
Collaborator

alckasoc commented Apr 15, 2025

Hello again!

Oh, UI-TARS-7B-DPO and 72B are used exclusively for grounding not as the main generation model (which is responsible for the DAG generation).

@alckasoc alckasoc self-assigned this Apr 15, 2025
@GeorgeCarpenter
Copy link
Contributor Author

Hello again!

Oh, UI-TARS-7B-DPO and 72B are used exclusively for grounding not as the main generation model (which is responsible for the DAG generation).

What main generation model do you use? @alckasoc

@alckasoc
Copy link
Collaborator

claude-3-7-sonnet-20250219 yields the best performance from our experiments. We also tested GPT-4o, but it was ~8% worse on OSWorld compared to Claude 3.7 Sonnet with thinking mode.

@GeorgeCarpenter
Copy link
Contributor Author

claude-3-7-sonnet-20250219 yields the best performance from our experiments. We also tested GPT-4o, but it was ~8% worse on OSWorld compared to Claude 3.7 Sonnet with thinking mode.

OK. Thanks.

@GeorgeCarpenter
Copy link
Contributor Author

Hello, how to set the grounding model and main generation model?

I would like to set the grounding model and main generation model seperately. However, there exists no param can be set for the two kinds of models in config() of osworld_setup.s2.run

Would you provide the param to set the grounding model and main generation model in config()?

Thanks.

@alckasoc alckasoc reopened this Apr 16, 2025
@alckasoc
Copy link
Collaborator

Hi @GeorgeCarpenter , I modified it to include the parameters. Please take a look.

@GeorgeCarpenter
Copy link
Contributor Author

I have fix the bug and contribute a pull request.

#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants