Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Type guards duplicated with the is #23

Open
younho9 opened this issue Dec 15, 2021 · 3 comments
Open

Question: Type guards duplicated with the is #23

younho9 opened this issue Dec 15, 2021 · 3 comments

Comments

@younho9
Copy link
Contributor

younho9 commented Dec 15, 2021

is provides type guards when using with TypeScript.

There are some duplicated functions like isFinite, isInteger, isSafeInteger. (Currently is does not seem to provide a type signature for the above functions.)

I wonder if is and ts-extras have different plans for type guards.

@sindresorhus
Copy link
Owner

The packages have different goals. There is a small overlap, yes, but only for a few functions.

@sindresorhus
Copy link
Owner

Currently is does not seem to provide a type signature for the above functions

Can you open an issue on is about that? I would be happy to see those methods have better type-guards.

@tychenjiajun
Copy link
Contributor

I think type guards in this repo should be work better for Array.prototype.filter and Array.prototype.every?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants