Skip to content

Commit d65342e

Browse files
committed
remove InstallPackages() page from wizard
1 parent f03d664 commit d65342e

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

venvipy/wizard.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,12 @@ def nextId(self):
124124
# process the flow only if the current page is BasicSettings()
125125
if self.currentId() != self.basic_settings_id:
126126
return super().nextId()
127-
if self.basic_settings.with_pip_check_box.isChecked():
128-
return self.install_packages_id
127+
# remove the InstallPackages() page as long as the `pip search`
128+
# command doesn't work (PyPI's XMLRPC API is currently disabled
129+
# due to unmanageable load and will be deprecated in the near
130+
# future. See https://status.python.org/ for more information)
131+
#if self.basic_settings.with_pip_check_box.isChecked():
132+
#return self.install_packages_id
129133
return self.final_page_id
130134

131135

@@ -325,7 +329,7 @@ def pop_combo_box(self):
325329
self.interpreter_combo_box.clear()
326330
self.interpreter_combo_box.addItem("---")
327331

328-
with open(get_data.DB_FILE, newline="") as cf:
332+
with open(get_data.DB_FILE, newline="", encoding="utf-8") as cf:
329333
reader = csv.DictReader(cf, delimiter=",")
330334
for info in reader:
331335
self.interpreter_combo_box.addItem(
@@ -342,8 +346,9 @@ def select_python(self):
342346
"Select Python Interpreter",
343347
"/usr/local/bin",
344348
"Python binary (\
345-
python3.3 python3.4 python3.5 python3.6 \
346-
python3.7 python3.8 python3.9 \
349+
python3.3 python3.4 python3.5 \
350+
python3.6 python3.7 python3.8 \
351+
python3.9 python3.10 python3.11 \
347352
)"
348353
)
349354
bin_file = file_name[0]
@@ -457,7 +462,7 @@ def finish_info(self):
457462
default_msg = (
458463
f"Virtual environment created \nsuccessfully. \n\n"
459464
f"New Python {self.python_version[7:10]} executable in \n"
460-
f"'{self.venv_location}/{self.venv_name}/bin'. \n"
465+
f"'{self.venv_location}/{self.venv_name}/bin'. \n"
461466
)
462467
with_pip_msg = ("Installed Pip and Setuptools.\n")
463468
with_wheel_msg = ("Installed Pip, Setuptools and Wheel.\n")
@@ -726,8 +731,8 @@ def __init__(self):
726731

727732
self.setTitle("Finished")
728733
self.setSubTitle(
729-
"All Tasks have been completed successfully. Click Finish "
730-
"to close the wizard and return back to the main menu."
734+
"All Tasks have been completed successfully. Click the Finish "
735+
"Button to close the wizard."
731736
)
732737

733738
h_layout = QHBoxLayout(self)
@@ -788,7 +793,7 @@ def initializePage(self):
788793
if __name__ == "__main__":
789794
finish_button.clicked.connect(self.wizard().force_exit)
790795

791-
# call update_zen_line to get a different line every new session
796+
# call update_zen_line() to get a different line every on new session
792797
self.wizard().refresh.connect(self.update_zen_line)
793798
self.wizard().refresh.emit()
794799

0 commit comments

Comments
 (0)