Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Table Grid Overflow & Non-sticky Header on Safari (Ag-Grid React Bug) #140

Open
jophy-ye opened this issue Feb 3, 2025 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jophy-ye
Copy link
Contributor

jophy-ye commented Feb 3, 2025

The class table grid is partially broken on Safari browsers (only).

Description

At first, class details were hidden because the table overflowed. A hot fix was deployed with #137. It seems that the <AgGridReact> component is not properly adhering to the parent <Box>'s width and height (set to width: 100% and height: 320px). According to the official docs, it should fit the parent container, but it appears not to on Safari (Webkit). This could potentially be a bug with ag-grid-react itself, though I am unsure at this point. (On the contrary, this page in the docs hints us to use style of <AgGridReact> which doesn't exist now. Kinda confusing...)

Furthermore, the sort-by-column switches is not rendered, and the table header is not sticky (check screenshots below).

Therefore, it seems a there is a fundamental bug with ag-grid (or how we use ag-grid) on webkit browsers.

Screenshot

螢幕截圖 2025-01-31 下午12 25 31 Look on my Safari browser, before #137

Safari 16.4 v.s. Chrome (on my Apple M2 MacBook Pro, Ventura 13.3.1)

TODO

It might be worth upgrading ag-grid-react to see if the issue persists, but we're using the latest version 33.0.4. Consider filing an issue with the ag-grid-react repository if the problem continues in newer versions. Would be great to investigate this further if I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants