Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths are constructed from a wrong basedir when importing markdown folder #14095

Closed
3 tasks done
kxxt opened this issue Feb 15, 2025 · 0 comments
Closed
3 tasks done
Assignees
Labels
Milestone

Comments

@kxxt
Copy link

kxxt commented Feb 15, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

With the following dir structure:

~/test 
❯ tree           
.
├── images
│   └── a.png
└── subdir
    └── a.md

3 directories, 2 files

~/test 
❯ cat subdir/a.md               
![img](../images/a.png)

When importing the test folder to Siyuan, the image is lost.

Siyuan tried to construct the abs path from ~/test and ../images/a.png, which leads to a non-existent path.

Instead it should construct the abs path from ~/test/subdir and ../images/a.png.

Expected result

The image should be there after the import.

Screenshot or screen recording presentation

No response

Version environment

- Version: Git master
- Operating System: Linux
- Browser (if used):

Log file

Not relevant

More information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants