Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mouse selection blocks #14010

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Improve mouse selection blocks #14010

merged 2 commits into from
Feb 5, 2025

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Feb 3, 2025

01 改进后效果:

video.webm

02 改进后效果:

video.webm

待解决:

还有 Shift+Click 多选块的问题需要 #14012 解决:

video.webm

@TCOTC TCOTC marked this pull request as draft February 3, 2025 16:02
@TCOTC TCOTC marked this pull request as ready for review February 3, 2025 16:49
@Vanessa219 Vanessa219 merged commit 2863eec into siyuan-note:dev Feb 5, 2025
6 checks passed
@Vanessa219 Vanessa219 self-requested a review February 5, 2025 03:37
@Vanessa219 Vanessa219 added this to the 3.1.21 milestone Feb 5, 2025
@TCOTC TCOTC deleted the fix/12120 branch February 5, 2025 05:12
Vanessa219 added a commit that referenced this pull request Feb 5, 2025
@Vanessa219 Vanessa219 self-assigned this Feb 5, 2025
@88250 88250 changed the title fix: 鼠标框选块或单元格时不应选中其中的文本 Improve mouse selection blocks Feb 6, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 7, 2025

这里为啥又去掉了,选中文本再按 Esc 就是不应该有选中背景的啊

image

@Vanessa219
Copy link
Member

然后shift+右选择文本没有背景色,这个需要统一处理,否则这个 bug 有点严重。

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 8, 2025

这个要怎么复现?我这样操作没问题:

video.webm

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 8, 2025

哦不对,是右方向键。

我觉得不显示还是合理的吧,毕竟选中块之后也不应该还能选择文本。

@Vanessa219
Copy link
Member

划选后,不要用鼠标,用键盘操作。

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 9, 2025

@Vanessa219 我试了一下,选中块之后是用不了 Shift+ 选择文本的(感觉挺合理的,其他三家也不允许这样操作)

video.webm

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 19, 2025

@Vanessa219 还有个问题,表格 .table__select 用 pointer-events:none; 的方法会有什么问题吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants