Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure node id is constant for sync node. Add common_bls_key to the schain config #1066

Merged
merged 6 commits into from
May 15, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Apr 29, 2024

Changes:

  1. Do not change node id after rotation.
  2. Add common_bls_key to the schain config.

Tests:

  1. Fixed corresponding unit tests.
  2. Tested on local network.

Performance:

  1. No performance related changes were introduced.

@badrogger badrogger changed the title Sync node. Ensure node id is constant. Add common bls key to the schain config Make sure node id is constant for sync node. Add common_bls_key to the schain config Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.59%. Comparing base (0ed6b90) to head (b9157e9).

Files Patch % Lines
sync_node.py 0.00% 8 Missing ⚠️
core/node_config.py 83.33% 1 Missing ⚠️
core/schains/config/generator.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.7.x    #1066      +/-   ##
==========================================
- Coverage   81.65%   81.59%   -0.06%     
==========================================
  Files         103      103              
  Lines        5946     5971      +25     
==========================================
+ Hits         4855     4872      +17     
- Misses       1091     1099       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review April 29, 2024 18:24
@badrogger badrogger merged commit bb8d657 into v2.7.x May 15, 2024
4 of 6 checks passed
@badrogger badrogger deleted the sync-bls-config branch May 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants