Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom schain patch timestamps #1068

Merged
merged 2 commits into from
May 10, 2024

Conversation

dmytrotkk
Copy link
Collaborator

This PR added support for custom patch timestamps based on env and sChain name.
Legacy patch timestamp format will remain supported.

Config format example:

schain:
  contractStorageZeroValuePatchTimestamp:
    default: 800000
    test-schain: 1500000
  revertableFSPatchTimestamp: 1000000
  contractStoragePatchTimestamp: 1000000

New tests added to tests/schains/config/static_params_test.py.
No performance changes.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (fbb2fb0) to head (002f607).

Additional details and impacted files
@@            Coverage Diff             @@
##           v2.7.x    #1068      +/-   ##
==========================================
+ Coverage   81.54%   81.57%   +0.03%     
==========================================
  Files         103      103              
  Lines        5906     5916      +10     
==========================================
+ Hits         4816     4826      +10     
  Misses       1090     1090              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmytrotkk dmytrotkk merged commit 13a95c1 into v2.7.x May 10, 2024
6 checks passed
@dmytrotkk dmytrotkk deleted the feature/add-custom-patch-ts-support branch May 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of different patchTimestamps for different chains
3 participants