Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease IMA time frame #1069

Merged
merged 6 commits into from
May 15, 2024
Merged

Decrease IMA time frame #1069

merged 6 commits into from
May 15, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented May 10, 2024

Changes:

  • Added migration for IMA time frame option in a same way the ima-agent was migrated during 2.2 release.

Tests:

  • Added new unit test. Fixed existing ones.
  • Tested on local network.

Performance:

  • No performance changes were introduced.

New time frame is configured using static_params.yaml (time_frame) config file.
Migration timestamp is configured in ima_migration_timestamp.yaml config file

@badrogger badrogger linked an issue May 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (13a95c1) to head (3dcc197).

Files Patch % Lines
tools/docker_utils.py 72.72% 3 Missing ⚠️
core/schains/ima.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.7.x    #1069      +/-   ##
==========================================
+ Coverage   81.57%   81.65%   +0.07%     
==========================================
  Files         103      103              
  Lines        5916     5946      +30     
==========================================
+ Hits         4826     4855      +29     
- Misses       1090     1091       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review May 10, 2024 16:19
dmytrotkk
dmytrotkk previously approved these changes May 13, 2024
@dmytrotkk dmytrotkk self-requested a review May 14, 2024 18:54
@badrogger badrogger merged commit 0ed6b90 into v2.7.x May 15, 2024
6 checks passed
@badrogger badrogger deleted the decrease-ima-frame branch May 15, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease time frame for agent frame
3 participants