Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty error logs #1134

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Fix empty error logs #1134

merged 3 commits into from
Nov 11, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 11, 2024

Changes:

  • Display logs if thread execution failed with an error

Testing

  • Modified unit tests
  • Tested on local network

Performance

  • No performance related changes were introduced

@badrogger badrogger linked an issue Nov 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.18%. Comparing base (9e7ea8f) to head (b4d99cc).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
core/schains/monitor/main.py 80.95% 4 Missing ⚠️
core/schains/monitor/tasks.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1134      +/-   ##
===========================================
- Coverage    83.24%   83.18%   -0.07%     
===========================================
  Files          102      102              
  Lines         6310     6323      +13     
===========================================
+ Hits          5253     5260       +7     
- Misses        1057     1063       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review November 11, 2024 13:10
@badrogger badrogger merged commit 007a365 into develop Nov 11, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skale sync admin couldn't re-create skaled on indexer node
3 participants