Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schain firewall config during cleaner stage #1140

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Jan 15, 2025

Changes

  • Make cleaner to remove schain firewall config

Testing

  • Modified unit tests
  • Tested on local network

Performance

  • No performance related changes were introduced

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 51.80723% with 40 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (59235f8) to head (4e6fd90).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
core/schains/firewall/nftables.py 23.33% 23 Missing ⚠️
core/schains/firewall/firewall_manager.py 33.33% 8 Missing ⚠️
core/schains/firewall/rule_controller.py 64.70% 6 Missing ⚠️
core/schains/firewall/utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
- Coverage    81.61%   81.41%   -0.21%     
===========================================
  Files          103      103              
  Lines         6517     6570      +53     
===========================================
+ Hits          5319     5349      +30     
- Misses        1198     1221      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review January 21, 2025 15:53
@badrogger badrogger merged commit 990e2f9 into develop Jan 23, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants