Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not increase failed_rpc_count when Rpc status is False #1143

Open
wants to merge 4 commits into
base: v2.10.x
Choose a base branch
from

Fix validator nodes check

f0f668b
Select commit
Loading
Failed to load commit list.
Open

Do not increase failed_rpc_count when Rpc status is False #1143

Fix validator nodes check
f0f668b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2025 in 0s

81.43% (+0.02%) compared to f45ac0a

View this Pull Request on Codecov

81.43% (+0.02%) compared to f45ac0a

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (f45ac0a) to head (f0f668b).

Files with missing lines Patch % Lines
core/node.py 0.00% 3 Missing ⚠️
core/schains/monitor/rpc.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v2.10.x    #1143      +/-   ##
===========================================
+ Coverage    81.41%   81.43%   +0.02%     
===========================================
  Files          103      103              
  Lines         6570     6573       +3     
===========================================
+ Hits          5349     5353       +4     
+ Misses        1221     1220       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.