Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-683 check rotation id before dkg broadcast #988

Merged
merged 7 commits into from
Dec 26, 2023

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Oct 2, 2023

fixes https://github.com/skalenetwork/internal-support/issues/683

added new parameter to broadcast function - rotation_id

@olehnikolaiev olehnikolaiev changed the base branch from develop to v2.6.x October 2, 2023 15:41
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bba42e4) 80.99% compared to head (003005f) 80.97%.

Files Patch % Lines
core/schains/dkg/main.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.6.x     #988      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files         101      101              
  Lines        5566     5571       +5     
==========================================
+ Hits         4508     4511       +3     
- Misses       1058     1060       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olehnikolaiev olehnikolaiev merged commit 7a0e7bf into v2.6.x Dec 26, 2023
4 of 7 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/IS-683-check-rotation-id-before-broadcast branch December 26, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants