Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1994 max fee per gas check #2073

Merged
merged 14 commits into from
Feb 13, 2025
Merged

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jan 10, 2025

fixes #1994

added patch timestamp MaxFeePerGasPatchTimestamp to add m_maxPriorityFeePerGas > m_maxFeePerGas check
in this case transaction should not be included to the pending transactions queue and Invalid transaction format error should be thrown

added MaxFeePerGasPatchTimestamp check when a transaction is added to the transaction queue or to the blockchain or is read from the database

added unit test JsonRpcSuite/maxFeePerGasPatch

no performance impact

@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Jan 16, 2025
@olehnikolaiev olehnikolaiev merged commit fb2b6e4 into v4.0.0 Feb 13, 2025
4 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1994-max-fee-per-gas-check branch February 13, 2025 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"maxFeePerGas" may be lower than maxPriorityFeePerGas
3 participants