Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/841 improve sgx related logs #2087

Closed
wants to merge 3 commits into from
Closed

Enhancement/841 improve sgx related logs #2087

wants to merge 3 commits into from

Conversation

PropzSaladaz
Copy link

@PropzSaladaz PropzSaladaz commented Jan 29, 2025 •
edited
Loading

Description

Added logs on libconsensus side to print errors returned from sgx server.

Tests

  • Tested changing ecdsaKeyName,and keyShareName for errors relative to fetching non-existent keys.
  • Tested changing the bls keys, but there were already error loggers on these.

Fixes skalenetwork/skale-consensus#841

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
@PropzSaladaz PropzSaladaz deleted the enhancement/841-improve-sgx-related-logs branch January 29, 2025 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PropzSaladaz