-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset subsystem status #2093
Merged
Merged
Reset subsystem status #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
kladkogex
previously approved these changes
Feb 4, 2025
olehnikolaiev
approved these changes
Feb 4, 2025
DmytroNazarenko
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent skale admin restarting skaled while database is being opened, it will utilise
subsystemRunning
section from skaled.status file. In particularRpc
field. To make sure that the field is false before rpc server is initialized, after skaled is started,Rpc
andBlockchain
fields are reseted.Related skale-admin pr: skalenetwork/skale-admin#1143
Tests
Additional tests added in StatusAndControlTest.cpp to cover status file operations.
The new behaviour was verified on local network as well as using standalone mode.
Performance Impact
All changes are related to skaled initialization procedure where only order of operation is changed.
No performance related changes were made.