Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset subsystem status #2093

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Reset subsystem status #2093

merged 9 commits into from
Feb 10, 2025

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Feb 4, 2025

Description

To prevent skale admin restarting skaled while database is being opened, it will utilise subsystemRunning section from skaled.status file. In particular Rpc field. To make sure that the field is false before rpc server is initialized, after skaled is started, Rpc and Blockchain fields are reseted.
Related skale-admin pr: skalenetwork/skale-admin#1143

Tests

Additional tests added in StatusAndControlTest.cpp to cover status file operations.
The new behaviour was verified on local network as well as using standalone mode.

Performance Impact

All changes are related to skaled initialization procedure where only order of operation is changed.
No performance related changes were made.

kladkogex
kladkogex previously approved these changes Feb 4, 2025
@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Feb 7, 2025
@DmytroNazarenko DmytroNazarenko merged commit 3ff7836 into v4.0.0 Feb 10, 2025
5 checks passed
@DmytroNazarenko DmytroNazarenko deleted the reset-subsystem-status branch February 10, 2025 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled not starts from the catchup for a long time after recreation of skaled-container
4 participants