Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/2090 Improve Sgx Logs #2096

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Enhancement/2090 Improve Sgx Logs #2096

merged 5 commits into from
Feb 19, 2025

Conversation

PropzSaladaz
Copy link

Description

  • Added error logs for SGX non-existent BLS & ECDSA key names
  • Improved log when blocks cannot be deserialized due to incorrect BLS key shares

Tests

  • Tested in local servers

@PropzSaladaz PropzSaladaz self-assigned this Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@PropzSaladaz PropzSaladaz changed the base branch from develop to v4.0.0 February 6, 2025 11:45
@PropzSaladaz PropzSaladaz linked an issue Feb 6, 2025 that may be closed by this pull request
Add more informative SGX related logs skalenetwork/skale-consensus#841
Closed
@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Feb 7, 2025
@PropzSaladaz PropzSaladaz changed the title Enhancement/2090 Improve Sgx Logs Enhancement/2090 Improve Sgx Logs [DO NOT MERGE] Feb 10, 2025
@PropzSaladaz PropzSaladaz changed the title Enhancement/2090 Improve Sgx Logs [DO NOT MERGE] Enhancement/2090 Improve Sgx Logs Feb 10, 2025
@olehnikolaiev olehnikolaiev self-requested a review February 10, 2025 19:17
olehnikolaiev
olehnikolaiev previously approved these changes Feb 10, 2025
View reviewed changes
@olehnikolaiev olehnikolaiev self-requested a review February 19, 2025 13:30
@PropzSaladaz PropzSaladaz merged commit 64665c6 into v4.0.0 Feb 19, 2025
5 checks passed
@PropzSaladaz PropzSaladaz deleted the enhancement/2090-improve-sgx-logs-2 branch February 19, 2025 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees

@PropzSaladaz PropzSaladaz

Labels
None yet
Projects
None yet
Milestone
SKALE 4.0
Development

Successfully merging this pull request may close these issues.

Add more informative SGX related logs
3 participants
@PropzSaladaz @DmytroNazarenko @olehnikolaiev