Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/885 Remove unused config fields #2100

Draft
wants to merge 5 commits into
base: v4.0.0
Choose a base branch
from
Draft

Enhancement/885 Remove unused config fields #2100

wants to merge 5 commits into from

Conversation

PropzSaladaz
Copy link

@PropzSaladaz PropzSaladaz commented Feb 11, 2025 •
edited
Loading

Description

  • Removed unused config fields

Tests

  • Tested compilation & running skaled

Fixes #885

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@PropzSaladaz PropzSaladaz linked an issue Feb 11, 2025 that may be closed by this pull request
Review and remove unused fields from the sChain config #885
Open
@PropzSaladaz PropzSaladaz self-assigned this Feb 12, 2025
@PropzSaladaz PropzSaladaz marked this pull request as draft February 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

@olehnikolaiev olehnikolaiev Awaiting requested review from olehnikolaiev

At least 2 approving reviews are required to merge this pull request.

Assignees

@PropzSaladaz PropzSaladaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and remove unused fields from the sChain config
1 participant
@PropzSaladaz