Skip to content

Shaderfilter overwrites the default OBS Studio wipes.json file, possibly destroying configuration options. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skeletonbow opened this issue May 16, 2022 · 1 comment
Labels
bad-practice BLOCKER Blocks the release of a new version of the software being released.

Comments

@skeletonbow
Copy link
Owner

OBS Shaderfilter 1.2.1 is installed by manually copying the 'data' and 'obs-plugins' directories out of the ZIP archive into the OBS Studio top level directory 'obs-studio'. The plugin contains additional luma-wipe transitions, and includes an updated 'wipes.json' config file to inform OBS about them, however since the plugin contains no installer, this simply overwrites the existing config file that ships with OBS which may or may not be newer, or may have been customized by the user, thus blowing away the configuration and overriding it.

A far better way of integrating into the OBS software would be to merge the desired changes into the file by modifying and integrating it into the JSON, either by processing it with a JSON library and adding entries during installation, or by using text file scraping methods. Likewise, upon uninstall, it should remove such entries from the OBS configuration.

This is bad form and could result in new luma wipes that get added to OBS by the project or by the user in having their configuration overwritten with old data.

@skeletonbow
Copy link
Owner Author

Here's a screenshot of the original file on the left, and the version Shaderfilter overwrites it with.
image

@skeletonbow skeletonbow added bug Something isn't working BLOCKER Blocks the release of a new version of the software being released. bad-practice and removed bug Something isn't working labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-practice BLOCKER Blocks the release of a new version of the software being released.
Projects
None yet
Development

No branches or pull requests

1 participant