#21 fix empty permissions saving

skn-036 · skn-036 · commit 28c8463148ad · 2024-01-27T12:45:29.000+06:00
diff --git a/app/Http/Controllers/RoleController.php b/app/Http/Controllers/RoleController.php
@@ -29,7 +29,7 @@ public function store(Request $request)
             }
             $role->save();
 
-            if ($request->permissions && is_array($request->permissions)) {
+            if (isset($request->permissions) && is_array($request->permissions)) {
                 $role->permissions()->sync($request->permissions);
             }
             return response()->json($role);
@@ -64,7 +64,7 @@ public function update(Request $request)
             }
             $role->save();
 
-            if ($request->permissions && is_array($request->permissions)) {
+            if (isset($request->permissions) && is_array($request->permissions)) {
                 $role->permissions()->sync($request->permissions);
             }
             return response()->json($role);

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function store(Request $request)`
`29`	`29`	`}`
`30`	`30`	`$role->save();`
`31`	`31`
`32`		`- if ($request->permissions && is_array($request->permissions)) {`
	`32`	`+ if (isset($request->permissions) && is_array($request->permissions)) {`
`33`	`33`	`$role->permissions()->sync($request->permissions);`
`34`	`34`	`}`
`35`	`35`	`return response()->json($role);`
`@@ -64,7 +64,7 @@ public function update(Request $request)`
`64`	`64`	`}`
`65`	`65`	`$role->save();`
`66`	`66`
`67`		`- if ($request->permissions && is_array($request->permissions)) {`
	`67`	`+ if (isset($request->permissions) && is_array($request->permissions)) {`
`68`	`68`	`$role->permissions()->sync($request->permissions);`
`69`	`69`	`}`
`70`	`70`	`return response()->json($role);`