Skip to content

Commit 629bbea

Browse files
authored
fix: bold and italic in list items proper indenting (#445)
fixes #444
1 parent fe23759 commit 629bbea

File tree

5 files changed

+43
-9
lines changed

5 files changed

+43
-9
lines changed

packages/core/demo/index.html

+11
Original file line numberDiff line numberDiff line change
@@ -851,6 +851,17 @@ <h3 class="title">Unordered list items</h3>
851851
<discord-list-item>deeper</discord-list-item>
852852
<discord-unordered-list>
853853
<discord-list-item>ain't that cool</discord-list-item>
854+
<discord-list-item>
855+
<discord-bold>we can also be bold</discord-bold>
856+
</discord-list-item>
857+
<discord-list-item>
858+
<discord-italic>or italic</discord-italic>
859+
</discord-list-item>
860+
<discord-list-item>
861+
<discord-bold>
862+
<discord-italic>or both</discord-italic>
863+
</discord-bold>
864+
</discord-list-item>
854865
</discord-unordered-list>
855866
</discord-unordered-list>
856867
</discord-unordered-list>

packages/core/src/components/discord-bold/DiscordBold.ts

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,17 @@
1-
import { LitElement, html } from 'lit';
1+
import { LitElement, css, html } from 'lit';
22
import { customElement } from 'lit/decorators.js';
33

44
@customElement('discord-bold')
55
export class DiscordBold extends LitElement {
6+
/**
7+
* @internal
8+
*/
9+
public static override readonly styles = css`
10+
:host > strong {
11+
font-weight: 700;
12+
}
13+
`;
14+
615
protected override render() {
716
return html`
817
<strong>

packages/core/src/components/discord-italic/DiscordItalic.ts

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,17 @@
1-
import { html, LitElement } from 'lit';
1+
import { css, html, LitElement } from 'lit';
22
import { customElement } from 'lit/decorators.js';
33

44
@customElement('discord-italic')
55
export class DiscordItalic extends LitElement {
6+
/**
7+
* @internal
8+
*/
9+
public static override readonly styles = css`
10+
:host > em {
11+
font-style: italic;
12+
}
13+
`;
14+
615
protected override render() {
716
return html`
817
<em>

packages/core/src/components/discord-list-item/DiscordListItem.ts

+1-7
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export class DiscordListItem extends LitElement {
99
*/
1010
public static override readonly styles = css`
1111
:host > li {
12-
white-space: break-spaces;
1312
margin-bottom: 4px;
1413
}
1514
`;
@@ -27,12 +26,7 @@ export class DiscordListItem extends LitElement {
2726

2827
protected override render() {
2928
this.checkParentElement();
30-
31-
return html`<!-- display: inline -->
32-
<li
33-
><span
34-
><span><slot></slot></span></span
35-
></li>`;
29+
return html`<li><slot></slot></li>`;
3630
}
3731
}
3832

packages/documentation/src/lit/components/DiscordComponentsWrapper.ts

+11
Original file line numberDiff line numberDiff line change
@@ -836,6 +836,17 @@ export class DiscordComponentsWrapper extends LitElement {
836836
<discord-list-item>deeper</discord-list-item>
837837
<discord-unordered-list>
838838
<discord-list-item>ain't that cool</discord-list-item>
839+
<discord-list-item>
840+
<discord-bold>we can also be bold</discord-bold>
841+
</discord-list-item>
842+
<discord-list-item>
843+
<discord-italic>or italic</discord-italic>
844+
</discord-list-item>
845+
<discord-list-item>
846+
<discord-bold>
847+
<discord-italic>or both</discord-italic>
848+
</discord-bold>
849+
</discord-list-item>
839850
</discord-unordered-list>
840851
</discord-unordered-list>
841852
</discord-unordered-list>

0 commit comments

Comments
 (0)