Skip to content

Commit 9f60afc

Browse files
authored
fix(string-select-menu): fixing clickable area (#488)
* fix(string-select-menu): fixing clickable area I fixed the clickable area to show the selectmenu options * fix: removing white spaces
1 parent 1f853cc commit 9f60afc

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

packages/core/src/components/discord-string-select-menu/DiscordStringSelectMenu.ts

+11-9
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,16 @@ export class DiscordStringSelectMenu extends LitElement implements LightTheme {
134134

135135
protected override render() {
136136
return html`
137-
<div class="${classMap({ 'discord-string-select-menu': true, 'discord-string-select-menu-disabled': this.disabled })}">
138-
<label class="discord-string-select-menu-label">
139-
<div class="${classMap({ 'discord-string-select-inside-menu': true, 'discord-string-select-menu-disabled': this.disabled })}">
140-
<span>${this.placeholder}</span> ${ExpandMore({ class: 'discord-expand-more-icon' })}
141-
<span class="discord-string-select-menu-hidden"><input type="checkbox" @click=${this._onClick} /></span>
142-
</div>
143-
</label>
144-
</div>
137+
<label
138+
class="${classMap({
139+
'discord-string-select-menu-label': true,
140+
'discord-string-select-menu': true,
141+
'discord-string-select-menu-disabled': this.disabled
142+
})}"
143+
>
144+
<span>${this.placeholder}</span> ${ExpandMore({ class: 'discord-expand-more-icon' })}
145+
<span class="discord-string-select-menu-hidden"><input type="checkbox" @click=${this._onClick} /></span>
146+
</label>
145147
<div class="discord-string-select-menu-option-slot discord-string-select-menu-hidden"><slot></slot></div>
146148
`;
147149
}
@@ -150,7 +152,7 @@ export class DiscordStringSelectMenu extends LitElement implements LightTheme {
150152
private _onClick() {
151153
const expandMoreIcon = this.shadowRoot?.querySelectorAll('svg.discord-expand-more-icon').item(0);
152154
const optionsMenu = this.shadowRoot?.querySelectorAll('div.discord-string-select-menu-option-slot').item(0);
153-
const stringSelectMenu = this.shadowRoot?.querySelectorAll('div.discord-string-select-menu').item(0);
155+
const stringSelectMenu = this.shadowRoot?.querySelectorAll('label.discord-string-select-menu').item(0);
154156

155157
if (stringSelectMenu?.className.includes('discord-string-select-menu-disabled')) return;
156158

0 commit comments

Comments
 (0)