MNT: parent args passed into Qt provided class __init__ should be positional args not use keyword arguments #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positional args not use keyword arguments For context: - Positional args: Func(1, 2) - Keyword args: Func(a=1, b=2) pyqt5 works still if we use the keyword argument 'parent' for super calls to qt class __init__ calls, but pyside6 throws an error (it generally seems a bit more strict about things). You can inspect an __init__ call (ex: 'print(inspect.signature(QLabel.__init__))') to see if/what keyword arguments are accepted by it. The __init__ calls changed in this patch don't accept a 'parent' keyword arg, just a positional arg for it. Also use int casting to avoid type errros in datetime widget.
nstelter-slac
force-pushed
the
fix_init_super_calls_pyside
branch
from
50b35b5 to
098b60a
Compare
|
realizing there more going on here than i originally thought, need to investigate a bit more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the following type of error on pyside6:
For context:
pyqt5 works still if we use the keyword argument 'parent' for super calls to qt provided classes __init__ calls, but pyside6 throws an error (it generally seems a bit more strict about things).
You can inspect an __init__ call (ex: 'print(inspect.signature(QLabel.__init__))') to see if/what keyword arguments are accepted by it.
The __init__ calls changed in this patch don't accept a 'parent' keyword arg, just a positional arg for it.
Also use int casting to avoid type erros in datetime widget.