Feat: hall of fame #7
Conversation
There was a problem hiding this comment.
Shall we remove this and use PNPM ? CI is configured to use it without which the workflows will fail
| {location.pathname !== "/halloffame" && ( | ||
| <div className="group flex gap-1.5 items-center"> | ||
| <a href="/halloffame" target="_blank" className="link ml-8 xl:ml-0" rel="noreferrer"> | ||
| The Hall of Fame | ||
| </a> | ||
| <LinkIcon className="transform -rotate-45 before:w-[1.2rem] xl:before:w/[0.6rem] before:group-hover:w/[1.45rem] xl:before:group-hover:w/[0.75rem] translate-y-[-0.1rem]" /> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Hall of fame isn't an external link therefore we won't need a redirection arrow and we could use the react router Link here to keep the navigation within the router. Also i feel that just Hall of Fame will be enough as the name
|
|
||
| const AnimatedRoutes = () => { | ||
| const location = useLocation(); | ||
| return ( | ||
| <AnimatePresence> | ||
| <Routes location={location}> | ||
| <Route path="/" element={<Home />} /> | ||
| <Route path="/halloffame" element={<HallOfFame />} /> |
There was a problem hiding this comment.
shall we use kebab case for the route as well ?
There was a problem hiding this comment.
Shall we use kebab case for the file name, all bashaway repositories follow the same pattern
There was a problem hiding this comment.
Also we can generalize the content from the main page into a component and reuse it here. This'll solve the code duplication
There was a problem hiding this comment.
It's kind of wrong to put round data files under utils folder, they're more suited under a path like json/annual-leaderboard/2023.json
| <div className="flex flex-col items-center gap-2 md:gap-1 mb-2"> | ||
| <Title className="tracking-normal pointer-events-none">The Hall of Fame</Title> | ||
| <Footnote className="text-black/40 max-w-[500px] text-xl lg:text-center leading-6 pointer-events-none"> | ||
| A place where your true colors show off despite all the differences |
There was a problem hiding this comment.
We'll probably need to change this subtitle
| @@ -12,6 +12,7 @@ | |||
| "dependencies": { | |||
| "@reduxjs/toolkit": "1.9.5", | |||
| "@sliit-foss/bashaway-ui": "0.12.3", | |||
| "bashaway-leaderboard": "file:", | |||
No description provided.