Merge pull request #77 from beatrycze-volk/ignore-phpstan

[BUGFIX] Ignore or correct PHPStan errors
slub · Jan 31, 2025 · 758315d · 758315d
2 parents 89a7e9a + 190f8a9
commit 758315d
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 5 deletions.
diff --git a/Classes/Controller/EditController.php b/Classes/Controller/EditController.php
@@ -64,7 +64,7 @@ public function updateAction(\In2code\Femanager\Domain\Model\User $user) {
      * @return void
      */
     public function disableAction() {
-        exit();
         $this->view->assign('user', $this->user);
+        exit();
     }
 }
diff --git a/Classes/Controller/ExtendController.php b/Classes/Controller/ExtendController.php
@@ -167,6 +167,7 @@ public function disableAction()
 
                 // second disable the account
                 $this->user->setDisable(true);
+                // @phpstan-ignore-next-line
                 $this->user->setInactivemessageTstamp(time());
                 $this->userRepository->update($this->user);
                 $this->persistenceManager->persistAll();

diff --git a/Classes/Controller/InvitationController.php b/Classes/Controller/InvitationController.php
@@ -71,6 +71,7 @@ public function createAction(\In2code\Femanager\Domain\Model\User $user)
      */
     public function updateAction(\In2code\Femanager\Domain\Model\User $user, $hash = null)
     {
+        // @phpstan-ignore-next-line
         $user->setTxFemanagerConfirmedbyuser(true);
         parent::updateAction($user);
     }

diff --git a/Classes/Controller/NewController.php b/Classes/Controller/NewController.php
@@ -93,7 +93,9 @@ public function createAction(\In2code\Femanager\Domain\Model\User $user)
             $user->setEmail($newEmailAddress);
             $user->setUsername($newEmailAddress);
             $user->setUsergroup($this->user->getUsergroup());
+            // @phpstan-ignore-next-line
             $user->setOldAccount($this->user->getUid());
+            // @phpstan-ignore-next-line
             $user->setTxFemanagerConfirmedbyuser(false);
         }
 

diff --git a/Classes/Controller/SearchController.php b/Classes/Controller/SearchController.php
@@ -63,7 +63,7 @@ public function injectSearchRepository(SearchRepository $searchRepository): void
     public function listAction()
     {
         $userUid = $this->user->getUid();
-
+        // @phpstan-ignore-next-line
         $this->view->assignMultiple([
             'savedSearches' => $this->searchRepository->findByFeUser($userUid),
             'token' => GeneralUtility::hmac((string)$userUid, (string) $this->user->getCrdate()->getTimestamp()),

diff --git a/Classes/Domain/Repository/StatisticRepository.php b/Classes/Domain/Repository/StatisticRepository.php
@@ -101,7 +101,7 @@ public function findForFilter($dateFrom = null, $dateTo = null, $feUserUid = nul
         if (!empty($feUserUid)) {
             $filterConditions[] = $queryBuilder->expr()->eq('fe_user', $feUserUid);
         }
-
+        // @phpstan-ignore-next-line
         $rows = $queryBuilder->where(...$filterConditions)
             ->execute()
             ->fetchAll();
@@ -155,7 +155,7 @@ public function findForStatistic($feUserUid = null)
         if (!empty($feUserUid)) {
             $queryBuilder->where($queryBuilder->expr()->eq('fe_user', $feUserUid));
         }
-
+        // @phpstan-ignore-next-line
         $rows = $queryBuilder->execute()->fetchAll();
 
         return $this->dataMapQueryResult($rows);

diff --git a/Classes/Hooks/FeUserHook.php b/Classes/Hooks/FeUserHook.php
@@ -71,7 +71,7 @@ public function initUserRepository()
      * check if user has changed e-mail/username on login
      *
      * @param array $params
-     * @return void
+     * @return mixed
      */
     public function checkChangedUsername(&$params)
     {