fix: skip class introspection when $ref is derived from annotation

Signed-off-by: Michael Edgar <michael@xlate.io>
Co-authored-by: Andrew Rouse <anrouse@uk.ibm.com>

Author: MikeEdgar

core/src/main/java/io/smallrye/openapi/runtime/scanner/OpenApiDataObjectScanner.java

@@ -10,7 +10,6 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.stream.BaseStream;
 
 import org.eclipse.microprofile.openapi.OASFactory;
@@ -38,7 +37,6 @@
 import io.smallrye.openapi.runtime.scanner.dataobject.IgnoreResolver;
 import io.smallrye.openapi.runtime.scanner.dataobject.TypeResolver;
 import io.smallrye.openapi.runtime.scanner.spi.AnnotationScannerContext;
-import io.smallrye.openapi.runtime.util.JandexUtil;
 import io.smallrye.openapi.runtime.util.TypeUtil;
 
 /**
@@ -257,19 +255,20 @@ private void depthFirstGraphSearch() {
 
             TypeUtil.mapDeprecated(context, currentClass, currentSchema::getDeprecated, currentSchema::setDeprecated);
             currentPathEntry.setSchema(currentSchema);
-            boolean hasImplementation = Optional.ofNullable(TypeUtil.getSchemaAnnotation(context, currentClass))
-                    .map(JandexUtil::hasImplementation)
-                    .orElse(false);
 
-            if (!hasImplementation && !hasNonNullType(currentSchema)) {
+            if (currentSchema.getRef() != null) {
+                continue;
+            }
+
+            if (!hasNonNullType(currentSchema)) {
                 // If not schema has yet been set, consider this an "object"
                 SchemaSupport.setType(currentSchema, Schema.SchemaType.OBJECT);
             } else if (allowRegistration) {
                 maybeRegisterSchema(currentType, currentSchema, entrySchema);
             }
 
             List<Schema.SchemaType> types = currentSchema.getType();
-            if (!hasImplementation && types != null && types.contains(Schema.SchemaType.OBJECT)) {
+            if (types != null && types.contains(Schema.SchemaType.OBJECT)) {
                 // Only 'object' type schemas should have properties of their own
                 ScannerLogging.logger.gettingFields(currentType, currentClass);
 

core/src/test/java/io/smallrye/openapi/runtime/scanner/StandaloneSchemaScanTest.java

@@ -1041,7 +1041,19 @@ public final boolean isNull() {
             // ... some other methods ...
         }
 
+        @Schema(ref = "#/components/schemas/1UseSchemaImplementationImpl")
+        class UseSchemaImplementationType2 {
+            private String value;
+            private final String internalValue = "internalValue";
+            private final Boolean composite = true;
+
+            public final boolean isNull() {
+                return value == null;
+            }
+            // ... some other methods ...
+        }
+
         assertJsonEquals("components.schemas.implementation-no-introspection.json", UseSchemaImplementationImpl.class,
-                UseSchemaImplementationType.class);
+                UseSchemaImplementationType.class, UseSchemaImplementationType2.class);
     }
 }

core/src/test/resources/io/smallrye/openapi/runtime/scanner/components.schemas.implementation-no-introspection.json

@@ -15,6 +15,9 @@
       },
       "1UseSchemaImplementationType" : {
         "$ref" : "#/components/schemas/1UseSchemaImplementationImpl"
+      },
+      "1UseSchemaImplementationType2" : {
+        "$ref" : "#/components/schemas/1UseSchemaImplementationImpl"
       }
     }
   }