Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSCAD CLI invocation for new --backend CLI option #386

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Update OpenSCAD CLI invocation for new --backend CLI option #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions site_scons/main_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,19 @@ def _openscad_cmd(self, env: SConsEnvironment) -> Sequence[str]:
"openscad", os.environ.get("OPENSCAD", "openscad")
)

def _openscad_has_features() -> bool:
def _openscad_has_backend_option() -> bool:
help_text = subprocess.run(
[executable, "--help"],
check=True,
capture_output=True,
text=True,
env=env["ENV"],
).stderr
return "--enable" in help_text
return "--backend" in help_text

cmd = [executable]
if _openscad_has_features():
cmd += ["--enable", "fast-csg", "--enable", "manifold"]
if _openscad_has_backend_option():
cmd += ["--backend", "Manifold"]
return cmd

def _add_openscad_builder(self, env: SConsEnvironment) -> None:
Expand Down
Loading