Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkling Aria cures burns from Pokemon with Shield Dust where it shouldn't #10293

Open
hedara90 opened this issue May 12, 2024 · 4 comments · May be fixed by #10882
Open

Sparkling Aria cures burns from Pokemon with Shield Dust where it shouldn't #10293

hedara90 opened this issue May 12, 2024 · 4 comments · May be fixed by #10882

Comments

@hedara90
Copy link

Sparkling Aria shouldn't cure burns from Pokemon with Shield Dust (and I'm assuming Covert Cloak too) in Single Battles.
Sparkling Aria correctly cures burns from Pokemon with Shield Dust in Double Battles where Sparkling Aria hits multiple Pokemon.
Sparkling Aria incorrectly cures burns from Pokemon with Shield Dust in Double Battles where Sparkling Aria hits only a single Pokemon.
Singles, shouldn't cure.
20240512_18h01m04s_grim

Doubles, should cure.
20240512_17h52m13s_grim

Doubles, shouldn't cure.
20240512_17h57m44s_grim

@Souvikns
Copy link

Souvikns commented Sep 25, 2024

According to bulbapedia,

Shield Dust prevents a Pokémon's burn being cured by Sparkling Aria if it is the only target of the attack (even in battles such as Double Battles, as long as there are no other targets of Sparkling Aria); however, if the attack has multiple targets, all targets will be cured on burn even if they have Shield Dust. (Wake-Up Slap and Smelling Salts, which also cure status conditions, are not considered to have additional effects and thus are not affected by Shield Dust.) This behavior is unique to Sparkling Aria—for example, Shield Dust prevents a Pokémon from being paralyzed by Discharge regardless of the number of targets.

I think this is happening because of this:

pokemon-showdown/data/moves.ts

Lines 18012 to 18018 in d155b49

onAfterMove(source, target, move) {
for (const pokemon of this.getAllActive()) {
if (pokemon !== source && pokemon.removeVolatile('sparklingaria') && pokemon.status === 'brn' && !source.fainted) {
pokemon.cureStatus();
}
}
},

I can open a PR for this.

@andrebastosdias
Copy link
Contributor

I'm working on this. If the move misses one of the Pokémon (or the other targets use Protect), does it still cure the burn on the Shield Dust Pokémon?

@hedara90
Copy link
Author

It's only in the case that the Shield Dust mon is the only one being hit by Sparkling Aria that burn doesn't get cured, it doesn't matter it it's due to Protect, semi-invulnerable or misses.

It's if the Shield Dust mon and any other mon getting hit by Sparkling Aria that the burn is cured.

@andrebastosdias
Copy link
Contributor

Just for completion, I checked that Covert Cloak works the same way as Shield Dust, and Sparkling Aria will cure burns even if all the Pokémon hit have Covert Cloak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants