-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis! #3341
Comments
What about windows support? Would we write a bash script and a batch script to support both? |
Yes, I'm pestering Morf about it in Dev as we speak. |
I'd rather there be an install script out of convenience rather than making users have to install Redis themselves. I'll write the install script once I finish setting up bhyve+qemu, since Virtualbox is rather slow on my machine |
Will Redis be a mandatory dependency? I was thinking of making the install script run on |
Yes, the only way we can really use it is as a mandatory dependency. |
Perfect |
On second thought, I was thinking of probably adding a regular RAM store for other servers... Kind of like what we do for ladders. Would be easier than installing a true database on literally everyone. |
What would that entail? |
Mostly work on my end. |
I'll keep what I had written in case it ends up becoming relevant again. |
No Windows support Fixes smogon#3341
No Windows support Fixes smogon#3341
No Windows support Fixes smogon#3341
No Windows support Fixes smogon#3341
Don't know if this is still being considered, but how viable would it be to suggest users run Redis through Docker? |
I don't really think we're planning to use Redis for anything anymore - sqlite / postgres are the planned backends. |
Yeah. I'd still prefer Redis to SQLite for performance reasons, but Redis apparently can't be included with We do still need to add persistent storage for battle logs though, to retain battles through restarts, and also to relieve some RAM pressure. |
Coughs in #7874 |
Redis is definitely the right in-memory database for our purposes. The problem is that we can't install Redis through
npm
. So... One of us should write a script to install Redis.Or I guess we could make users install it themselves. But I like the script idea.
The text was updated successfully, but these errors were encountered: