Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis! #3341

Open
Zarel opened this issue Mar 6, 2017 · 14 comments · May be fixed by #8545
Open

Redis! #3341

Zarel opened this issue Mar 6, 2017 · 14 comments · May be fixed by #8545

Comments

@Zarel
Copy link
Member

Zarel commented Mar 6, 2017

Redis is definitely the right in-memory database for our purposes. The problem is that we can't install Redis through npm. So... One of us should write a script to install Redis.

Or I guess we could make users install it themselves. But I like the script idea.

@panpawn
Copy link
Contributor

panpawn commented Mar 6, 2017

What about windows support? Would we write a bash script and a batch script to support both?

@Zarel
Copy link
Member Author

Zarel commented Mar 6, 2017

Yes, I'm pestering Morf about it in Dev as we speak.

@Morfent
Copy link
Contributor

Morfent commented Mar 6, 2017

I'd rather there be an install script out of convenience rather than making users have to install Redis themselves. I'll write the install script once I finish setting up bhyve+qemu, since Virtualbox is rather slow on my machine

@Morfent
Copy link
Contributor

Morfent commented Mar 15, 2017

Will Redis be a mandatory dependency? I was thinking of making the install script run on npm post-install so users don't have to remember to run it themselves

@Zarel
Copy link
Member Author

Zarel commented Mar 15, 2017

Yes, the only way we can really use it is as a mandatory dependency.

@Morfent
Copy link
Contributor

Morfent commented Mar 15, 2017

Perfect

@Zarel
Copy link
Member Author

Zarel commented Mar 15, 2017

On second thought, I was thinking of probably adding a regular RAM store for other servers... Kind of like what we do for ladders. Would be easier than installing a true database on literally everyone.

@Morfent
Copy link
Contributor

Morfent commented Mar 15, 2017

What would that entail?

@Zarel
Copy link
Member Author

Zarel commented Mar 15, 2017

Mostly work on my end.

@Morfent
Copy link
Contributor

Morfent commented Mar 15, 2017

I'll keep what I had written in case it ends up becoming relevant again.

Morfent added a commit to Morfent/Pokemon-Showdown that referenced this issue Mar 16, 2017
Morfent added a commit to Morfent/Pokemon-Showdown that referenced this issue Mar 16, 2017
Morfent added a commit to Morfent/Pokemon-Showdown that referenced this issue Mar 16, 2017
Morfent added a commit to Morfent/Pokemon-Showdown that referenced this issue Mar 16, 2017
@DylanSp
Copy link
Contributor

DylanSp commented Jan 24, 2021

Don't know if this is still being considered, but how viable would it be to suggest users run Redis through Docker?

@mia-pi-git
Copy link
Member

Don't know if this is still being considered, but how viable would it be to suggest users run Redis through Docker?

I don't really think we're planning to use Redis for anything anymore - sqlite / postgres are the planned backends.

@Zarel
Copy link
Member Author

Zarel commented Jan 25, 2021

Yeah. I'd still prefer Redis to SQLite for performance reasons, but Redis apparently can't be included with npm install and I don't want to maintain too many separate database backends anyway, so we're not going to do this.

We do still need to add persistent storage for battle logs though, to retain battles through restarts, and also to relieve some RAM pressure.

@mia-pi-git
Copy link
Member

We do still need to add persistent storage for battle logs though, to retain battles through restarts, and also to relieve some RAM pressure.

Coughs in #7874

@mia-pi-git mia-pi-git linked a pull request Nov 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants