Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove |callback| in favor of |error| + updated request #5414

Closed
scheibo opened this issue Apr 5, 2019 · 0 comments
Closed

Remove |callback| in favor of |error| + updated request #5414

scheibo opened this issue Apr 5, 2019 · 0 comments

Comments

@scheibo
Copy link
Contributor

scheibo commented Apr 5, 2019

There was discussion on #5370 about this, but #5370 (comment) discovered the existing error message is insufficent, and either making |error| structured or resending the updated request along with an |error| would be required to replace |callback|. If we resent the request with approriate information updated (ie. maybeTrapped -> trapped, etc), it would remove the need for RandomPlayerAI to have any state, at the cost of additional bandwidth usage in the error cases (expected to be negligible in terms of oveall bandwidth impact).

scheibo added a commit to pkmn-archive/pokemon-showdown that referenced this issue Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant