Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider marking some Choice tests as '(slow)' #5496

Open
scheibo opened this issue May 10, 2019 · 0 comments
Open

Consider marking some Choice tests as '(slow)' #5496

scheibo opened this issue May 10, 2019 · 0 comments

Comments

@scheibo
Copy link
Contributor

scheibo commented May 10, 2019

297b7a9 marked some of the more niche tests as '(slow)', but the next logical tests to mark '(slow)' come from within test/sim/decisions.js which is more core, so I wanted to get some feedback around whether we'd be willing to move these to the fulltest suite to improve developer velocity.

Choices
    Switch requests
      √ should allow specifying the team order in a slot-per-slot basis in Triples (275ms)
    Logging
      √ should privately log shifting decisions for the Pokémon on the left (279ms)
      √ should privately log shifting decisions for the Pokémon on the right (202ms)
  Choice extensions
    Undo
      √ should disallow to revoke switch decisions on move requests for unconfirmed trapping-immune Pokémon that would otherwise be trapped (228ms)
      √ should support to revoke shift decisions on move requests (420ms)
      √ should disallow to revoke shift decisions by default (551ms)
      √ should support to override shift decisions on move requests (336ms)
      √ should disallow to override shift decisions by default (338ms)
  Choice internals
    √ should allow input of move commands in a per Pokémon basis (368ms)
    √ should allow input of switch commands in a per Pokémon basis (117ms)
    √ should allow input of move and switch commands in a per Pokémon basis (150ms)
    √ should empty the actions list when undoing a move (137ms)
    √ should empty the actions list when undoing a switch (142ms)
    √ should empty the actions list when undoing a pass (149ms)
    √ should empty the actions list when undoing a shift (258ms)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant