-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amulet coin isn't in items #6989
Comments
I'm not opposed to Amulet Coin, but we usually draw the line at items with no competitive relevance. (Balls and bottle caps don't have relevance as held items, but they're used competitively in other ways which makes them convenient to include.) |
would you happen to know how to add the image of the item? I would love to be able to do it myself on my own fork of the repository. |
Images are unfortunately not open-source, and so can't be easily changed with a pull request or anything like that. |
well drat. Thank you anyway. |
Every item that existed in Gen 5, no matter how irrelevant, is already in the sprite sheet: https://play.pokemonshowdown.com/sprites/itemicons-sheet.png You just have to point at it with |
Thank you! |
So, I tried adding the item and it seems that the code ignores the sprite number I give it. I even tried making another item look like it and it changed nothing. Is this set up in another location other than data -> items? |
It requires both server and client changes (server changes should be in |
build full? |
By default, the testclient will take data files from |
Oh! Alright, thank you |
How do you do a full build? I have been trying for awhile and have no idea how to do it. |
Use the command |
Alright, it didn't work. I edited data -> items and added the item. Any idea what could be keeping it from working? I even tried changing an existing item's sprite number. That seems to be the only location that stores items unless there is another repository I need to use? (unrelated question, can I and how do I register my own showdown server so it can save replays?) Edit: let me clerify. No listed or unlisted use of the build full command i have found allows the item to show up. |
we have every Pokeball (as far as I checked) and bottle caps, but no amulet coin?
The text was updated successfully, but these errors were encountered: