Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amulet coin isn't in items #6989

Open
EvGym opened this issue Jul 9, 2020 · 15 comments
Open

amulet coin isn't in items #6989

EvGym opened this issue Jul 9, 2020 · 15 comments

Comments

@EvGym
Copy link
Contributor

EvGym commented Jul 9, 2020

we have every Pokeball (as far as I checked) and bottle caps, but no amulet coin?

@Zarel
Copy link
Member

Zarel commented Jul 9, 2020

I'm not opposed to Amulet Coin, but we usually draw the line at items with no competitive relevance.

(Balls and bottle caps don't have relevance as held items, but they're used competitively in other ways which makes them convenient to include.)

@EvGym
Copy link
Contributor Author

EvGym commented Jul 10, 2020

would you happen to know how to add the image of the item? I would love to be able to do it myself on my own fork of the repository.

@Zarel
Copy link
Member

Zarel commented Jul 10, 2020

Images are unfortunately not open-source, and so can't be easily changed with a pull request or anything like that.

@EvGym
Copy link
Contributor Author

EvGym commented Jul 10, 2020

well drat. Thank you anyway.

@Zarel
Copy link
Member

Zarel commented Jul 10, 2020

I believe @monsanto and @Marty-D were most recently working on sprites and would know how to add an item sprite.

@Marty-D
Copy link
Collaborator

Marty-D commented Jul 10, 2020

Every item that existed in Gen 5, no matter how irrelevant, is already in the sprite sheet: https://play.pokemonshowdown.com/sprites/itemicons-sheet.png You just have to point at it with spritenum.

@EvGym
Copy link
Contributor Author

EvGym commented Jul 11, 2020

Thank you!

@EvGym
Copy link
Contributor Author

EvGym commented Jul 11, 2020

So, I tried adding the item and it seems that the code ignores the sprite number I give it. I even tried making another item look like it and it changed nothing. Is this set up in another location other than data -> items?

@Zarel
Copy link
Member

Zarel commented Jul 12, 2020

It requires both server and client changes (server changes should be in client/data/pokemon-showdown), and build full. Are you doing both?

@EvGym
Copy link
Contributor Author

EvGym commented Jul 12, 2020

build full?

@Zarel
Copy link
Member

Zarel commented Jul 12, 2020

By default, the testclient will take data files from play.pokemonshowdown.com. If you do a build full in place of build, you will instead build and use your own copy of the data files from a clone of the server repository in data/Pokemon-Showdown/.

@EvGym
Copy link
Contributor Author

EvGym commented Jul 12, 2020

Oh! Alright, thank you

@EvGym
Copy link
Contributor Author

EvGym commented Jul 12, 2020

How do you do a full build? I have been trying for awhile and have no idea how to do it.
I have been trying commands like "npm run-script build full" but nothing seems to happen.

@AnnikaCodes
Copy link
Collaborator

How do you do a full build?

Use the command node build full.

@EvGym
Copy link
Contributor Author

EvGym commented Jul 12, 2020

Alright, it didn't work. I edited data -> items and added the item. Any idea what could be keeping it from working? I even tried changing an existing item's sprite number.

That seems to be the only location that stores items unless there is another repository I need to use?

(unrelated question, can I and how do I register my own showdown server so it can save replays?)

Edit: let me clerify. No listed or unlisted use of the build full command i have found allows the item to show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants