Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mold Breaker interactions with abilities' Start events #10877

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix Mold Breaker interactions with abilities' Start events #10877

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b455bb
Wind Rider's Start event is suppressed by Mold Breaker
andrebastosdias Feb 10, 2025
7af41ad
Ice Face's Start event is suppressed by Mold Breaker
andrebastosdias Feb 10, 2025
2996c11
Refactor using breakable
andrebastosdias Feb 10, 2025
39f3145
Fix breakable check
andrebastosdias Feb 10, 2025
3a0e8e7
Cloud Nine's Start event is suppressed by Mold Breaker
andrebastosdias Feb 10, 2025
a386057
Revert "Cloud Nine's Start event is suppressed by Mold Breaker"
andrebastosdias Feb 10, 2025
82e60ae
Add generic test
andrebastosdias Feb 13, 2025
0fd3b08
Merge branch 'master' into mold-breaker
andrebastosdias Feb 26, 2025
997e91f
Update to ESLint 9
andrebastosdias Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix breakable check
  • Loading branch information
@andrebastosdias
andrebastosdias committed Feb 10, 2025
commit 39f314533eaa0b81cd47619883e7f303643f1b27
6 changes: 5 additions & 1 deletion sim/battle.ts
View file
Original file line number Diff line number Diff line change
@@ -568,6 +568,11 @@ export class Battle {
// it's changed; call it off
return relayVar;
}
if (eventid === 'SwitchIn' && effect.effectType === 'Ability' && effect.flags['breakable'] &&
this.suppressingAbility(target as Pokemon)) {
this.debug(eventid + ' handler suppressed by Mold Breaker');
return relayVar;
}
if (eventid !== 'Start' && eventid !== 'TakeItem' && effect.effectType === 'Item' &&
(target instanceof Pokemon) && target.ignoringItem()) {
this.debug(eventid + ' handler suppressed by Embargo, Klutz or Magic Room');
@@ -826,7 +831,6 @@ export class Battle {
Boost: 1,
DragOut: 1,
Effectiveness: 1,
Start: 1,
};
if (eventid in AttackingEvents) {
this.debug(eventid + ' handler suppressed by Mold Breaker');