-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AfterMoveSecondaryLast event #10899
base: master
Are you sure you want to change the base?
Add AfterMoveSecondaryLast event #10899
Conversation
this.battle.singleEvent('AfterMoveSecondarySelf', move, null, pokemon, target, move); | ||
this.battle.runEvent('AfterMoveSecondarySelf', pokemon, target, move); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how the other per-move AfterMoveSecondarySelf
handlers should resolve priority compared to other AfterMoveSecondarySelf
effects, but in case it helps, you can combine them in one priority system as follows:
this.battle.singleEvent('AfterMoveSecondarySelf', move, null, pokemon, target, move); | |
this.battle.runEvent('AfterMoveSecondarySelf', pokemon, target, move); | |
this.battle.runEvent('AfterMoveSecondarySelf', pokemon, target, move, null, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That code isn't mine, so I'd prefer not to touch it. For AfterMoveSecondaryLast
, I used the template from AfterMoveSecondary
.
Oh, I've been confusing |
I can change it to |
You’re running Pickpocket in there which is supposed to be suppressed by Sheer Force. It should probably have a name that reflects that (doesn’t this event run before |
Yeah, you're right, and yes, it does! |
Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
Currently applies only to Ice Spinner and Pickpocket.
Fixes:
Let me know if there are any other effects that should activate during this event.
Edit: does it make sense to check for
EmergencyExit
after the new event?