Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dancer using the battle queue and the AnyAfterMove event #10975

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

andrebastosdias
Copy link
Contributor

@andrebastosdias andrebastosdias commented Mar 16, 2025

Closes #10929

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Mar 18, 2025

With our current knowledge, this PR is ready for review. I would like to run some tests for Gens 8+ to check if anything changed with the new queue system that updates after every action.

@pyuk-bot tested, and indeed, in Gen 9, Pokémon activate the Dancer ability from fastest to slowest (and take speed modifiers into account). This PR is ready for review!

https://www.smogon.com/forums/threads/scarlet-violet-battle-mechanics-research.3709545/post-10486072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mechanic Bug: Dancer & Eject Button resolve in the wrong order
2 participants