Store timestamp in the log

[Antar1011]

Resolves #2731

So that the data can be accessed without needing the folder structure.

[Antar1011]

And then I have a question about L1045/1048:

let tier = this.format.toLowerCase().replace(/[^a-z0-9]+/g, '');

Shouldn't this just be toId(this.format)?

[Zarel]

Can we remove some redundant data while we're at it?

[Zarel]

A lot of fields in p1rating/p2rating are superfluous. The individual formatid's and entryids, for one.

[Antar1011]

That would be fine with me, but I'm not sure how to do it in a future-proofed way (say the colname in the db changes, then delete p1rating.formatid would throw an error, no?)

[Antar1011]

Or if you're worried about space, you could always just tackle #2733

[Zarel]

You're cute when talking about languages you don't know.

There's not a single language for which it's impossible to delete a key from a map if you're not sure if the key exists. Every language at the very least has a "does this key exist?" function (except ObjC for some weird reason).

Anyway, delete p1rating.formatid won't throw if p1rating.formatid doesn't exist, it just silently fails.

[Antar1011]

@Zarel, as I said, I don't know how to do it in JS. I never said it wasn't possible to do it.

But let's identify the redundant keys:

That would be:

• formatid
• username (since it's encoded separately as p[n])
• userid (since you can always toId(username))

And if we don't care about future-proofing, we can ditch

• rpsigma
• sigma

col1 (number of battles for the alt, even past the last reset) might be a useful, but seeing as how it's not documented, I'm fine with dropping it as well.

Does js have a "delete all" or do you just have to iterate?

[Zarel]

Iterate.

I'm fine with all of the above, although keeping userid may be nice.

[Zarel]

Um, JSON doesn't support storing dates. It will toJSON the date, which I believe makes it a string. Is that what you want, or do you want a numeric timestamp?

[Antar1011]

Yeah, I'm fine with strings. In theory this could introduce TZ issues, but I'd rather have readability. If you care, I'm fine with numeric, though.

[Zarel]

Okay, but you should probably do the conversion explicitly new Date().toString(), so future people who read your code know that it's intentional and not accidental.