Change how status type is encoded in the protocol #5627
Conversation
| const statusMessage = this.statusType === 'busy' ? '!(Busy) ' : this.statusType === 'idle' ? '!(Idle) ' : ''; | ||
| const status = statusMessage + (this.userMessage || ''); | ||
| return status; | ||
| return this.statusType === 'idle' ? '@!' : this.statusType === 'busy' ? '@' : /* online */ ''; |
There was a problem hiding this comment.
Whether Idle should be @ or @? is up on the fence still, I think?
| return this.statusType === 'idle' ? '@!' : this.statusType === 'busy' ? '@' : /* online */ ''; | |
| return this.statusType === 'busy' ? '@!' : this.statusType === 'idle' ? '@' : /* online */ ''; |
There was a problem hiding this comment.
No, Zarel is pretty vehement about Busy as @ and Idle as @!, so the code as written should correctly reflect his preference.
There was a problem hiding this comment.
Oh, I reverted it in my brain and thought he wanted @! for busy and @ idle, my bad.
There was a problem hiding this comment.
Yeah, we want @! for Busy which is why its so confusing, but to Zarel, Busy is ⊥, and I'm tired to arguing.
|
Hm, looks like you'll also need to change:
|
Zarel
force-pushed
the
master
branch
2 times, most recently
from
c7b57c2 to
1d09dd1
Compare
Not to be merged until the client can handle the new protocol. We might need to also give bot developers a heads up as well? Discussion is all on #5590