Roomlogs: Use Redis to store scrollback #8545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it should also be noted that this means scrollbacks will persist through restarts. |
mia-pi-git
force-pushed
the
redis
branch
6 times, most recently
from
541454f to
5238071
Compare
AnnikaCodes
reviewed
Nov 30, 2021
|
Checks are failing and there are merge conflicts :[ |
|
Also @Zarel do you have thoughts on this? |
|
This needs the merge conflicts to be resolved and a review from @Zarel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts out scrollback storage into a class implementing an interface - currently, we support both in-memory and Redis. Promises have been propagated accordingly (though I avoided propagating in Roomlog#add due to the level of traffic in it).
(Apologies if there are test failures originally, my ESLint was crashing on this fsr, so I couldn't lint.)
Closes #3341.