Skip to content

chore: update to stable snakemake #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Sep 7, 2024

Summary by CodeRabbit

  • Chores
    • Updated the dependency specification for the snakemake package to ensure a stable version (8.20.0) is used, enhancing the reliability of the environment.

Copy link
Contributor

coderabbitai bot commented Sep 7, 2024

Walkthrough

The change involves updating the dependency specification for the snakemake package in the pyproject.toml file. The previous configuration sourced snakemake directly from a Git repository, while the updated configuration specifies that version 8.20.0 should be used. This modification shifts from a direct Git reference to a versioned release.

Changes

Files Change Summary
pyproject.toml Updated snakemake dependency from Git repository to version 8.20.0.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DependencyManager
    participant GitRepo
    participant PackageRepo

    User->>DependencyManager: Request for snakemake
    alt Old Configuration
        DependencyManager->>GitRepo: Fetch latest commit
        GitRepo-->>DependencyManager: Return latest snakemake
    else New Configuration
        DependencyManager->>PackageRepo: Fetch version 8.20.0
        PackageRepo-->>DependencyManager: Return snakemake 8.20.0
    end
    DependencyManager-->>User: Provide snakemake
Loading

Poem

🐇 In the garden where I hop and play,
A change has come to brighten the day!
From Git's wild branches, we now take flight,
With version 8.20.0, everything feels right!
Hooray for stability, let’s dance and cheer,
For a smoother journey throughout the year! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c414f65 and 05309b0.

Files selected for processing (1)
  • pyproject.toml (1 hunks)
Additional comments not posted (1)
pyproject.toml (1)

28-28: Approve the dependency update but verify compatibility.

The update from a Git repository to a specific version (8.20.0) of snakemake is a positive change for stability and reproducibility. However, it's crucial to ensure that this version is compatible with other dependencies and the overall project requirements.

Run the following script to verify the compatibility of snakemake version 8.20.0 with other dependencies:

@cmeesters
Copy link
Member

oh, hm, why is there now an explicit version instead of the URI?

@cmeesters cmeesters merged commit edadd3e into main Sep 7, 2024
4 of 5 checks passed
@cmeesters cmeesters deleted the johanneskoester-patch-1 branch September 7, 2024 15:50
@johanneskoester
Copy link
Contributor Author

Fix incoming: snakemake/snakemake#3077

@johanneskoester
Copy link
Contributor Author

The test still failed...

@johanneskoester
Copy link
Contributor Author

Why the merge already?

@johanneskoester
Copy link
Contributor Author

The fix is not yet released.

@cmeesters
Copy link
Member

Why the merge already?

The change is merely in the toml, pointing to an existing snakemake release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants