-
Notifications
You must be signed in to change notification settings - Fork 29
chore: test changes in testing framework in main branch of snakemake #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change involves updating the dependency declaration for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant GitHub
User->>System: Request to install snakemake
System->>GitHub: Fetch latest snakemake version
GitHub-->>System: Provide latest snakemake code
System-->>User: Install snakemake from GitHub
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- pyproject.toml (1 hunks)
Additional comments not posted (1)
pyproject.toml (1)
28-28
: Consider the implications of sourcingsnakemake
directly from its Git repository.Switching the
snakemake
dependency from a version constraint to a direct Git repository link allows for the use of the latest commits, potentially accessing features or fixes not yet released. However, this change can introduce risks:
- Instability: The main branch may not always be stable, potentially introducing breaking changes or bugs.
- Reproducibility: Builds may vary over time without a locked version, making it harder to reproduce issues or ensure consistent behavior across environments.
Consider using a more stable branch or tagging a specific commit in the Git repository to mitigate these risks:
snakemake = { git="https://github.com/snakemake/snakemake", branch="stable" }or
snakemake = { git="https://github.com/snakemake/snakemake", rev="a1b2c3d" }
Ok, works again with the main branch. Fixes are now released in snakemake 8.20.1 |
Summary by CodeRabbit