fix: added forgotten yield in case of job preemption

[cmeesters]

Summary by CodeRabbit

• New Features
  • Enhanced job management by improving the responsiveness of active job status checks.
  • Added functionality to yield job information when certain conditions are met, allowing for better processing of active jobs.

[coderabbitai]

Walkthrough

The pull request modifies the check_active_jobs function in the snakemake_executor_plugin_slurm/__init__.py file by adding a line to yield job information when the job status is neither "UNKNOWN" nor other specified states. This change improves the function's control flow, allowing for more effective processing of active jobs.

Changes

Files	Change Summary
snakemake_executor_plugin_slurm/__init__.py	Added yield j in function check_active_jobs

Poem

🐰 In the meadow where jobs do play,
A new line added brightens the day.
With statuses checked, we hop and we yield,
Active jobs flourish, their fates now revealed.
So let's dance and rejoice, for changes are here,
In the world of Snakemake, we cheer with good cheer! 🎉

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8adfbf8 and 6159844.

Files selected for processing (1)

• snakemake_executor_plugin_slurm/init.py (1 hunks)

Additional comments not posted (1)

snakemake_executor_plugin_slurm/__init__.py (1)

364-364: LGTM!

The change to yield j when the job status is neither "UNKNOWN" nor any other specified state is a good addition. It allows the function to provide job information to the caller in more cases, potentially enabling better handling of active jobs.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.